Repository navigation
Conversation
4394c4f to
a1d3d98
Compare
5775721 to
777b281
Compare
|
/ocabot rebase |
|
@nimarosa The rebase process failed, because command |
|
@stferraro please rebase to see if it has no conflicts since it's a old PR. I can't do it automatically because you disabled access to your branch. If everything pass again i merge it. |
|
This PR has the |
777b281 to
73fc9d3
Compare
|
@nimarosa the rebase went through clean (no conflicts) and all checks are green now — pre-commit, tests on Odoo and OCB, codecov, and runboat all passed. Ready for you to merge whenever you get a chance. Thanks! |
|
Hi @nimarosa , please merge this module to merge ! |
|
Any news on the status of this pull request? I would like to see this in 19.0. Thank you. |
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/ca/
Currently translated at 16.6% (4 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/es_VE/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/es/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/tr/
In Odoo 17.0+, the address_home_id field was removed from hr.employee and replaced with work_contact_id. This caused journal entries to be created without proper partner information when no register partner was configured. This fix implements proper partner resolution logic: - For asset_receivable and liability_current accounts: Use employee partner (work_contact_id with fallback to bank_account_id.partner_id) - For liability_payable accounts: Use register partner - For other account types: No partner assigned Also includes proper null checks to prevent AttributeError when accessing .id on empty Many2one fields. Added minimal test coverage for the new partner logic to verify correct partner assignment for different account types. Fixes OCA#221
73fc9d3 to
9cc3da2
Compare
9cc3da2 to
ef16a76
Compare
|
Hi @nimarosa, thanks again for the review. I rebased this PR onto the current 19.0 and squashed it into a single [MIG] commit. While comparing with #294 (@amincheloh), which migrates the same module, I took three improvements from it and credited them in the commit message:
This PR was already approved, so could you check that the CI is green and merge it? @amincheloh, thanks for the ideas. I would be glad to coordinate if you see anything else worth bringing here. |
|
The following commit authors need to sign the Contributor License Agreement: |
Related #260
Related #228
cc @CristianoMafraJunior @tishmen @nimarosa @dreispt