Repository navigation
[19.0][FIX] payroll: test_get_contracts_multiple fails on the last day of the month - #321
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
Contributor
|
Hi @appstogrow, @nimarosa, |
dreispt
approved these changes
Nov 4, 2026
The second contract started tomorrow, which is in the next month on the last day of a month, so only 2 contracts were found for the payslips of the current month. Put both contracts in the middle of the month. Assisted-by: Claude Opus 5.5
parabol123654
force-pushed
the
19.0-fix-payroll-month-end-test
branch
from
November 14, 2026 18:04
1bb427e to
4029efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPayslipFlow.test_get_contracts_multiplefails when the tests run on the last day of a month (e.g. today, 2026-10-31):The test ends Sally's first contract today and starts her second contract tomorrow, expecting both in the payslips of the current month. On the last day of a month, tomorrow is in the next month, so the second contract is out of the payslip period.
The change keeps the same scenario (two sequential contracts within the current month) with fixed days: first contract from the 1st to the 15th, second from the 16th. Test only.
Locally (with demo data):
payroll1 failure out of 27 today without the change, 27/27 with it.Assisted-by: Claude Opus 5.5