Repository navigation
[18.0][FIX] payroll: contribution register wizard dates evaluated when the server starts - #322
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
Contributor
|
Hi @appstogrow, @nimarosa, |
dreispt
approved these changes
Nov 4, 2026
…server starts The default dates were computed when the module was imported, so the wizard proposed the month the Odoo server was started. Assisted-by: Claude Opus 5.5
parabol123654
force-pushed
the
18.0-fix-payroll-contribution-register-dates
branch
from
November 14, 2026 18:19
fd02b7e to
e314a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaults of
date_fromanddate_toonpayslip.lines.contribution.register(PaySlip Lines by Contribution Register wizard) are computed withdatetime.now()when the module is imported. If the server was started in October and the report is printed in November, the wizard still proposes October 1st to October 31st.The fix computes the defaults when the wizard is opened: the first and last day of the current month, using
fields.Date.context_today.The new test opens the wizard inside
freeze_time("2030-02-15"). Without the fix it fails withFakeDate(2026, 10, 1) != FakeDate(2030, 2, 1). 19.0 has the same code; I will forward-port it after merge.Assisted-by: Claude Opus 5.5