[17.0][BKP] webservice_server_env: make server_environment an optional dependency - #153
Open
yankinmax wants to merge 5 commits into
Open
[17.0][BKP] webservice_server_env: make server_environment an optional dependency#153yankinmax wants to merge 5 commits into
yankinmax wants to merge 5 commits into
Conversation
Contributor
|
Hi @etobella, |
OCA-git-bot
added
mod:webservice
yankinmax
force-pushed
the
17.0-remove-server-env-dep-webservice
branch
from
August 19, 2026 08:18
18abc64 to
8b3a59a
Compare
3 tasks
yankinmax
changed the title
ivantodorovich
approved these changes
Aug 19, 2026
yankinmax
force-pushed
the
17.0-remove-server-env-dep-webservice
branch
2 times, most recently
from
August 19, 2026 14:25
fc4921d to
172ded2
Compare
yankinmax
force-pushed
the
17.0-remove-server-env-dep-webservice
branch
from
August 20, 2026 06:38
172ded2 to
6e574d4
Compare
…umns on uninstall
yankinmax
force-pushed
the
17.0-remove-server-env-dep-webservice
branch
from
August 24, 2026 07:36
6e574d4 to
f8766a3
Compare
PR#146 split server_environment out of `webservice` into the optional `webservice_server_env` module, but the logic resetting `oauth2_flow` when `auth_type` is no longer "oauth2" only lived in `webservice_server_env`'s `_compute_server_env` override. Without `server_environment` installed, switching a backend's `auth_type` away from "oauth2" (via the UI or a plain write) silently left a stale `oauth2_flow`, which `_get_adapter_protocol` would then still factor into the selected component. Add an `_onchange_auth_type` plus `create`/`write` overrides on `webservice.backend` itself so the reset is guaranteed unconditionally, independent of `server_environment`. `webservice_server_env`'s own override is unchanged and still covers its own case (env-var-driven values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of:
Depends on:
And a fix for
endpoint_auth_api_key:endpoint_auth_api_key: expect 401 when API key is missing #154Includes: