[18.0][FIX] endpoint: serialize payload values with Odoo's json_default - #163
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
[18.0][FIX] endpoint: serialize payload values with Odoo's json_default#163AungKoKoLin1997 wants to merge 1 commit into
AungKoKoLin1997 wants to merge 1 commit into
Conversation
_make_json_response called json.dumps() with no default= hook, so any payload value json cannot represent natively raised TypeError and the request returned a 500. Every other JSON response in Odoo goes through json.dumps(data, default=json_default) (odoo/http.py). Pass the same hook here. It covers date, datetime, bytes, lazy and ReadonlyDict, and json.dumps applies it at every depth, so nested values are handled without walking the payload. Also let an endpoint supply its own hook through the result dict, for exec modes that need to override how a type is rendered. json.dumps takes a single default= callable, so such a hook replaces Odoo's for the whole payload and is expected to delegate to json_default for the types it does not render itself. Backport of OCA#160. Assisted-by: Claude Opus 5
Contributor
|
Hi @simahawk, |
AungKoKoLin1997
marked this pull request as ready for review
September 2, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #160 to 18.0.
_make_json_response called json.dumps() with no default= hook, so any payload value json cannot represent natively raised TypeError and the request returned a 500. Every other JSON response in Odoo goes through json.dumps(data, default=json_default) (odoo/http.py).
Pass the same hook here. It covers date, datetime, bytes, lazy and ReadonlyDict, and json.dumps applies it at every depth, so nested values are handled without walking the payload.
Also let an endpoint supply its own hook through the result dict, for exec modes that need to override how a type is rendered. json.dumps takes a single default= callable, so such a hook replaces Odoo's for the whole payload and is expected to delegate to json_default for the types it does not render itself.
Differences from the 19.0 PR:
demo/endpoint_demo.xml, since 18.0 still keeps the demo endpoints in demo data rather than intests/common.py.Domaindoes not exist in 18.0 (ir.rule._compute_domainreturns a plain list), so the demo payload and the HTTP test only coverdate/datetime.Assisted-by: Claude Opus 5
@qrtl QT6815