Fixes - #804
Merged
Merged
Conversation
clairblacketer
left a comment
clairblacketer
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this @ganisimov! It looks like the line endings were handled through the csvs but that the order by random fix and the primary key fix were done to the ddls themselves. Should these be addressed in future through fixes to Sql Render? I am concerned that if we re-generate the ddls at any point using the csvs we will lose your changes here.
Collaborator
Author
|
@clairblacketer , the z-order fix is done by using correct hint for SqlRender, and the primary key issue was fixed by using the latest version of SqlRender to generate the DDLs. So that to end up with the same DLLs one just needs to ensure that the latest SqlRender is installed. |
Contributor
|
Amazing as always, thank you @ganisimov! I will pull this in then |
clairblacketer
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.