[superwhiskers]

Description

this modifies some of the formatting rules to make lambda expressions a bit more readable when used inline within a function call.

Proposed changes

• adjust continuation indentation and bracket alignment
• apply formatting fixes across the repository

Checklist

• All tests pass.
• Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
• The new code follows GridKit™ style guidelines.
• There are unit tests for the new code.
• The new code is documented.
• The feature branch is rebased with respect to the target branch.
• The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

[read-the-docs-community]

Documentation build overview

📚 GridKit | 🛠️ Build #35625223 | 📁 Comparing 2810da6 against latest (9963c0d)

  🔍 Preview build  

159 files changed · + 68 added · ± 69 modified · - 22 deleted

+ Added

• api/reference/classGridKit_1_1CoSim_1_1CoSim.html
• api/reference/classGridKit_1_1CoSim_1_1detail_1_1Channel.html
• api/reference/classGridKit_1_1CoSim_1_1detail_1_1PeerFailure.html
• api/reference/classGridKit_1_1CoSim_1_1detail_1_1Stopped.html
• api/reference/dir_GridKit_CoSim.html
• api/reference/enum_namespaceGridKit_1_1CoSim_1_1detail_1af7a12d7b8ccabbf033e2bd143e4d62d5.html
• api/reference/enum_namespaceGridKit_1_1CoSim_1a465bcffd863fd890a500f315bfcf174a.html
• api/reference/enum_namespaceGridKit_1_1CoSim_1a471cbc96a8875b14fc17021551280c85.html
• api/reference/enum_namespaceGridKit_1_1CoSim_1ad3d568e7efb1854aca2f446e37f9e67d.html
• api/reference/enum_namespaceGridKit_1_1PhasorDynamics_1_1Controller_1a66f8c7d54bb07fa22c0624fbcad99e27.html
• and 58 more...

± Modified

• genindex.html
• development/CHANGELOG.html
• api/reference/classAnalysisManager_1_1NativeDynamicSolver_1_1FixedStep.html
• api/reference/classAnalysisManager_1_1NativeDynamicSolver_1_1Rosenbrock.html
• api/reference/classAnalysisManager_1_1SteadyState_1_1IpoptInterface.html
• api/reference/classAnalysisManager_1_1Sundials_1_1Kinsol.html
• api/reference/classAnalysisManager_1_1Sundials_1_1SundialsException.html
• api/reference/classGridKit_1_1Model_1_1OptimizationEvaluator.html
• api/reference/classGridKit_1_1OptimalPowerFlow_1_1Branch.html
• api/reference/classGridKit_1_1OptimalPowerFlow_1_1Bus.html
• and 59 more...

- Deleted

• api/reference/typedef_namespaceGridKit_1_1OptimalPowerFlow_1a53bb75d71b0e6d0d0c6ce23943825ca6.html
• api/reference/typedef_namespaceGridKit_1_1OptimalPowerFlow_1a93f7d200c41e5c0b9345fed27662feab.html
• api/reference/typedef_namespaceGridKit_1_1OptimalPowerFlow_1aab3a3d7ace0fa735a019a86162abf645.html
• api/reference/typedef_namespaceGridKit_1_1OptimalPowerFlow_1acf1e838eb687e31f976510dc824ec22b.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Controller_1a0abe611be812ff021bec23e9c4bf0a5c.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Controller_1a36ad654bd2e7f4f5ca9065e9fc6e7fe9.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Converter_1a9dd49f70a47e8f4906e60bf011f7bf51.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Exciter_1a553b0643af0f9540072c9c10339d4f81.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Exciter_1a5fc1571479293bebfbce0502215f2f95.html
• api/reference/typedef_namespaceGridKit_1_1PhasorDynamics_1_1Exciter_1af73c7862e83c6147ba61e23135accdc4.html
• and 12 more...

[nkoukpaizan]

I'm not convinced this is a good idea. It touches a lot of files, and makes some things harder to read in order to improve lambdas (which I usually avoid anyway).

[nkoukpaizan]

This reads worse than the previous version.

[superwhiskers]

there's some manual effort i need to put in to make the formatting look right because the formatter won't automatically do it. i just pushed an update of how that should look.

the reason the formatter won't do it automatically is because we unbound the maximum line length in the formatting configuration. i believe this was done to avoid touching so many files in the initial formatting approach but it has the disadvantage of not automatically doing things like the change i just made.

[superwhiskers]

if you and others are open to reversing this, i'd propose a column limit of 80. this would reduce the amount of manual effort required to make the code look nice at the cost of reformatting a lot of the codebase.

personally, i think this is worth it, but it has been brought up before

[pelesh]

Style changes are not priority right now and changing 300+ files is too much of a distraction at this point.