Repository navigation
Reject duplicate PhasorDynamics IDs and report unknown signal IDs - #645
Draft
nkoukpaizan wants to merge 1 commit into
Draft
nkoukpaizan wants to merge 1 commit into
nkoukpaizan wants to merge 1 commit into
Conversation
nkoukpaizan
force-pushed
the
nicholson/verify-ids
branch
from
November 4, 2026 22:18
a89ba0b to
6805dc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This validates IDs in PhasorDynamics models.
Proposed changes
SystemModel::verify()that reports every repeated bus number, signal ID, device ID per class, and subsystem ID. The top system walks its tree once, so subsystems don't repeat the check.INPUT_FORMAT.mdaccordingly.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
The checks live in$N \times log N$ in the number of IDs. Validating per subsystem would scale as $N \times S \times log(N/S)$ .
verify()rather than in separate per-level checks, so one call reports all problems together. They use temporarystd::sets, one insert per ID, so the cost isDraft until we merge #644, and I'll change the base to develop.