Skip to content

Fix redundant printing in HyKKT - #476

Merged
shakedregev merged 3 commits into
developfrom
slaven/verbosity-fix
Oct 5, 2026
Merged

shakedregev merged 3 commits into
developfrom
slaven/verbosity-fix

Conversation

@pelesh

@pelesh pelesh commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Remove printing of AMD header and suppress printing error messages in HyKKT solver test.

Every time ordering is called the AMD preamble is printed to standard output whether user wants it or not. This PR turns off the AMD info printing.

Fixes #474.

Proposed changes

  • Mute logger when testing HyKKT's response to erroneous input.
  • Remove printing AMD library header altogether.

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • N/A I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Printing error messages when testing error response
is confusing to users.
@pelesh
pelesh requested a review from andrewxu319 September 30, 2026 19:15
@pelesh pelesh self-assigned this Sep 30, 2026
@pelesh
pelesh requested a review from shakedregev October 3, 2026 12:46

@shakedregev shakedregev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just move the comment so that it's more clear what it refers to.

Comment thread tests/unit/hykkt/HykktSolverTests.hpp Resolved
Comment thread tests/unit/hykkt/HykktSolverTests.hpp Resolved
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
@shakedregev
shakedregev merged commit 7899a32 into develop Oct 5, 2026
@shakedregev
shakedregev deleted the slaven/verbosity-fix branch October 5, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: HyKKT prints debugging output on stdout

2 participants