Repository navigation
Fix redundant printing in HyKKT - #476
Merged
Merged
Conversation
Printing error messages when testing error response is confusing to users.
shakedregev
approved these changes
Oct 5, 2026
shakedregev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I would just move the comment so that it's more clear what it refers to.
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove printing of AMD header and suppress printing error messages in HyKKT solver test.
Every time ordering is called the AMD preamble is printed to standard output whether user wants it or not. This PR turns off the AMD info printing.
Fixes #474.
Proposed changes
Checklist
make testandmake test_installper testing instructions). Code tested on./examples/<your_example>.exe -hto get instructions how to run examples). Code tested on:-Wall -Wpedantic -Wconversion -Wextra.Further comments