[shakedregev]

Description

System solver decided quietly how to interpret a user's erroneous input.

Proposed changes

Returns errors instead of warnings when the user's meaning is unclear.

Checklist

• All tests pass (make test and make test_install per testing instructions). Code tested on
  • CPU backend
  • CUDA backend
  • HIP backend
• I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
  • CPU backend
  • CUDA backend
  • HIP backend
• Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
• The new code follows Re::Solve style guidelines.
• There are unit tests for the new code.
• The new code is documented.
• The feature branch is rebased with respect to the target branch.
• I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

[shakedregev]

Rerunning CI and fixing comments.

[kakeueda]

Looks good to me.

[pelesh]

I would replace "throw" with "return" because "throw usually implies an exception. Other suggestions are optional.

[shakedregev]

Fixed throw to return.

Fixed.

[pelesh]

Error is correctly identified and proper message is returned.