difftest: skip REF on nemu_trap - #285
Closed
good-circle wants to merge 2 commits into
Closed
good-circle wants to merge 2 commits into
good-circle wants to merge 2 commits into
Conversation
Mark NutCoreTrap commits as skip so the reference does not execute the custom-trap encoding. DiffTest still stops the sim on a0=0/1; otherwise the comparison is skipped. Forward isNutCoreTrap through in-order EXU so WBU can set skip.
Pin OpenXiangShan/difftest to 128ace159 (circle-patch1) so control markers 0x100/0x101 keep the sim running.
poemonsense
reviewed
Sep 20, 2026
poemonsense
left a comment
poemonsense
left a comment
Collaborator
There was a problem hiding this comment.
Do we still need this if trap always exits the simulation?
Collaborator
Author
No, this is unnecessary. I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.