Repository navigation
Conversation
Contributor
|
Hi. Why were you testing krovak with false easting or northing? Is there any official CRS like that? |
Author
|
No, not that I know of. All the EPSG ones use the same value for both. We're adding projection support in MapLibre, so I was fuzzing PROJ and proj4js for inconsistencies, and this was one of them. It still matters for custom strings, since the forward already handles different values correctly and only the inverse mixes them up. It's been like this since 9.4.0, when mod_krovak was added. |
jjimenezshaw
approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+proj=krovakwith different+x_0and+y_0doesn't round-trip. With+x_0=100 +y_0=0, 16.85°E 50.21°N comes back ~280 m away, because the inverse applies the false easting to the northing and the false northing to the easting. All EPSG Krovak CRSs use equal values, so they aren't affected.This PR applies each offset to its own axis, the same way as the forward.