Repository navigation
r.boxplot: remove debug print statement and add testsuite - #1697
Valyrian-Code wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds automated tests for the r.boxplot module and removes an unintended debug print from the implementation.
Changes:
- Introduce a new Python test suite validating output generation, zonal mode, required parameters, and a flag path.
- Remove a stray
print()call fromr.boxplot.pythat could pollute stdout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/raster/r.boxplot/testsuite/test_r_boxplot.py | New unit tests covering basic success and failure modes of r.boxplot. |
| src/raster/r.boxplot/r.boxplot.py | Removes a debug print(vect_name) from the outliers-map creation branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ecodiv
left a comment
There was a problem hiding this comment.
The edit in the code is fine. Testsuite looks OK, but I did not test it.
Thanks. Ran the testsuite locally on GRASS 8.5.0 (conda-forge, osx-arm64) inside an active session. All 5 tests pass: Tests cover:
cc @ecodiv |
|
Oh, as what happened in the grass repo this weekend, this PR is made from the default branch of your fork, and will cause problems. Create a branch specifically for your PR, and open a new PR. |
Summary
print(vect_name)debug statement inbxp_nozones()that leaked an internal Python list directly to stdout, bypassing normal GRASS output handling.Test plan
Verify all tests pass:
Verify pre-commit checks pass on modified files
Notes
A separate issue (#1696) tracks MASK loss when
zones=is used and the script exits with an error. That issue is unrelated to this PR.