Skip to content

g.extension: Disable multi-addon addon metadata check for addons which install only man page - #2090

Merged
tmszi merged 4 commits into
OSGeo:mainfrom
tmszi:g_extension-fix-check-multi-addon-metadata
Jan 14, 2022
Merged

tmszi merged 4 commits into
OSGeo:mainfrom
tmszi:g_extension-fix-check-multi-addon-metadata

Conversation

@tmszi

@tmszi tmszi commented Jan 13, 2022 •

Copy link
Copy Markdown
Member

Describe the enhancement
Disable checking multi-addon addons metadata for multi-addon containing addons which install only *.html manual
page e.g. i.sentinel multi-addon contains i.sentinel addon which install i.sentinel.html manual page. This addon metadata check produces "a confusing warning message" (it isn't bug) for the user.

To Reproduce
Steps to reproduce the behavior:

  1. Install multi-addon e.g. g.extension i.sentinel
  2. See warning message during installation
GRASS nc_basic_spm_grass7/PERMANENT:~ > g.extension i.sentinel
Fetching <i.sentinel> from GRASS GIS Addons repository (be patient)...
Compiling...
Installing...
Updating extensions metadata file...
Updating extension modules metadata file...
WARNING: No metadata available for module 'i.sentinel': Unable to fetch
         interface description for command '<i.sentinel>'.

         Details: <[Errno 2] No such file or directory: 'i.sentinel'>
Installation of <i.sentinel> successfully finished

Expected behavior
Disable checking multi-addon addons metadata for multi-addon containing addons which install only *.html manual
page.

GRASS nc_basic_spm_grass7/PERMANENT:~ > g.extension i.sentinel
Fetching <i.sentinel> from GRASS GIS Addons repository (be patient)...
Compiling...
Installing...
Updating extensions metadata file...
Updating extension modules metadata file...
Installation of <i.sentinel> successfully finished

System description:

  • GRASS GIS version main, releasebranch_8_0, releasebranch_7_8

Additional context
#2082 (comment)

For multi-addon containing addons which install only *.html manual
page e.g. i.sentinel multi-addon contains i.sentinel addon which
install i.sentinel.html manual page.
@tmszi tmszi added enhancement New feature or request backport_needed labels Jan 13, 2022
@tmszi
tmszi requested a review from neteler January 13, 2022 19:46
@tmszi tmszi added this to the 8.0.0 milestone Jan 13, 2022
Comment thread scripts/g.extension/g.extension.py Resolved
Comment thread scripts/g.extension/g.extension.py Resolved
@neteler

neteler commented Jan 13, 2022

Copy link
Copy Markdown
Member

I tried it locally after patching with g.extension i.sentinel but the warning still appears.
Not sure how to debug it properly...

@tmszi

tmszi commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

I tried it locally after patching with g.extension i.sentinel but the warning still appears. Not sure how to debug it properly...

You're doing the right thing, the mistake is on my side, I copied the code incorrectly from my test environment. Sorry about that.

@tmszi

tmszi commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

I've already fixed it d075b1a.

@neteler neteler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works fine!

@tmszi
tmszi merged commit 4f17220 into OSGeo:main Jan 14, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Jan 14, 2022
…Geo#2090)

For multi-addons which contains addons which install only *.html manual
page e.g. the i.sentinel multi-addon consists of several full i.sentinel.*
addons along with a i.sentinel.html overview file.
tmszi added a commit to tmszi/grass that referenced this pull request Jan 14, 2022
…Geo#2090)

For multi-addons which contains addons which install only *.html manual
page e.g. the i.sentinel multi-addon consists of several full i.sentinel.*
addons along with a i.sentinel.html overview file.
@tmszi
tmszi deleted the g_extension-fix-check-multi-addon-metadata branch January 14, 2022 13:34
@wenzeslaus wenzeslaus changed the title scripts/g.extension: disable checking multi-addon addons metadata for multi-addon containing addons which install only *.html manual page g.extension: Disable checking multi-addon addons metadata for multi-addon containing addons which install only *.html manual page Apr 27, 2022
@wenzeslaus wenzeslaus changed the title g.extension: Disable checking multi-addon addons metadata for multi-addon containing addons which install only *.html manual page g.extension: Disable multi-addon addon metadata check for addons which install only man page Apr 27, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
…Geo#2090)

For multi-addons which contains addons which install only *.html manual
page e.g. the i.sentinel multi-addon consists of several full i.sentinel.*
addons along with a i.sentinel.html overview file.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
…Geo#2090)

For multi-addons which contains addons which install only *.html manual
page e.g. the i.sentinel multi-addon consists of several full i.sentinel.*
addons along with a i.sentinel.html overview file.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
…Geo#2090)

For multi-addons which contains addons which install only *.html manual
page e.g. the i.sentinel multi-addon consists of several full i.sentinel.*
addons along with a i.sentinel.html overview file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants