Repository navigation
CI: introduce setup-msys2@v2 setup action - #2508
Conversation
ninsbl
added
backport_needed
windows
hellik
left a comment
hellik
left a comment
There was a problem hiding this comment.
The yml changes are looking good.
Regarding the cairo issue, some more checks why it pops up again may be good.
|
Working now... Since OSGeo4W checks succeed for #2506 too, it seems the issue was a bug in MSYS2. So, I guess checks would now pass also without these changes. Seems to be messed up OSGeo4W vs. MSYS2 cairo... Still, the PR makes the workflow a bit cleaner and avoids mixing OSGeo4W and MSYS2 cairo library. And using BTW: cairo-devel from OSGeo4W does not seem to provide a cairo.pc, thus the warning about pkg-config... |
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Great work - I cannot judge in detail but the fact that the CI job finally compiles again is a good sign :)
I did take a look at the Cairo code and couldn't find any related changes there. I suppose(d) it was build set up related somehow... Great you found the way! |
|
Backported in #2510 |
|
FYI, the OSGeo4W check passed four days ago on August 1 for c0a83a3. That's before this was merged in 53b69fb. See the recent commits on main: |
Thanks @nilason, @neteler and @hellik for your feedback. It has indeed been a build env issue. Will create a follow up PR for backporting... * use msys2-setup * specify location * get OSGeo4W includes for cairo * try to deactivate fontconfig * remove msys2 cairo * link osgeo4w cairo * link osgeo4w cairo libs * no fontconfig
Thanks @nilason, @neteler and @hellik for your feedback. It has indeed been a build env issue. Will create a follow up PR for backporting... * use msys2-setup * specify location * get OSGeo4W includes for cairo * try to deactivate fontconfig * remove msys2 cairo * link osgeo4w cairo * link osgeo4w cairo libs * no fontconfig
Thanks @nilason, @neteler and @hellik for your feedback. It has indeed been a build env issue. Will create a follow up PR for backporting... * use msys2-setup * specify location * get OSGeo4W includes for cairo * try to deactivate fontconfig * remove msys2 cairo * link osgeo4w cairo * link osgeo4w cairo libs * no fontconfig
For using MSYS in CI (esp. github) it is recommended to use msys2/setup-msys2@v2 action. See also: https://www.msys2.org/docs/ci/
This PR introduces that action and should make the build pass again without errors.
Replaces #2468
Should also speedup the test a few minutes and maybe simplifies to explore other possibilities (e.g. using UCRT)