Repository navigation
Conversation
01b0516 to
d868f5c
Compare
HuidaeCho
added
bug
| /* point plotting, alternative to G_plot_point() | ||
| * x, y are col, row numbers */ | ||
| void plot_point(double east, double north) |
There was a problem hiding this comment.
If it is an alternative, does that mean that if changes to the G_plot_point() are made, they may need to be kept in sync/compatible with the function here? If so, should we add a note in the comments of G_plot_point() to refer back here (to not forget in the future)?
| x = ifloor(X(G_adjust_easting(east, &st->window)) + 0.5); | ||
| y = ifloor(Y(north) + 0.5); |
There was a problem hiding this comment.
Any reason why not to use G_plot_where_xy here?
There was a problem hiding this comment.
st in G_plot_where_xy() is static and internal to libgis. dense_line.c has its own st.
neteler
added
the
backport to 8.4
|
This seems like a good candidate to still push for 8.5, any thoughts @HuidaeCho @marisn ? |
I agree. |
|
The cross-reference note agreed in 2024 does not look like it landed, the PR touches only the three files under Worth doing, since the new Read from source, I have not built it. |
This PR addresses #3105. It implements a new
plot_point()function that uses the internalstateindense_line.c. CallingG_plot_point()with-dflag causes a segfault because the staticstateinlibgisis not shared with any modules.