Repository navigation
build: Fix findstr syntax for Windows build - #7343
Merged
Merged
Conversation
echoix
approved these changes
Apr 27, 2026
echoix
approved these changes
Apr 27, 2026
echoix
left a comment
Member
There was a problem hiding this comment.
Seems like a weird previous behavior. Trusting your testing, as you're probable the one that will fix it if doesn't work.
Would there be an advantage to use CMake's file(READ), string(REPLACE), and file(WRITE)? Would it end up simpler or with better documentation, even if done in three steps? Probably wouldn't be faster on Linux, but might be easier to debug if it's the same on all platforms. But it differs from the autotools build
Member
Author
|
This might be possible, but file(READ "${IN}" txt)
string(REPLACE "</body>" "" txt "${txt}")
string(REPLACE "</html>" "" txt "${txt}")
string(REPLACE "</div> <!-- end container -->" "" txt "${txt}")
file(WRITE "${OUT}" "${txt}") |
Contributor
|
@HuidaeCho Shall we backport this to 8.5? |
wenzeslaus
pushed a commit
that referenced
this pull request
May 8, 2026
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
findstrsyntax.findstruses spaces fororand sometimes requires/rfor regex (even though it's the default?).Without this PR, generated HTML files are broken, causing: