[metzm]

PR #7351 could not be backported to GRASS 8.4 because there is no G_strlcat() in G84. This PR uses a portable workaround of strlen + strcat

[echoix]

Assuming build passes

[metzm]

Build failed in lib/raster with

vrt.c: In function ‘Rast_get_vrt_row’:
vrt.c:186: error: ignoring ‘#pragma omp critical’ [-Werror=unknown-pragmas]
  186 | #pragma omp critical(raster_vrt_read)
      | 
vrt.c:205: error: ignoring ‘#pragma omp critical’ [-Werror=unknown-pragmas]
  205 | #pragma omp critical(raster_vrt_read)
      | 
cc1: all warnings being treated as errors

Any idea why #pragma omp critical is an unknown pragma in G84, but not in G85 and G86?

Local build is fine of course.

[echoix]

OpenMP version is different maybe?

[metzm]

OpenMP version is different maybe?

No, build test for G84 is broken: if compiling without openMP support and the C compiler flag -Werror=unknown-pragmas is set, all #pragma omp .. occurrences cause a build error.

[metzm]

This line in the ubuntu workflow vould be a reason: https://github.com/OSGeo/grass/blob/releasebranch_8_4/.github/workflows/ubuntu.yml#L139 in particular -Werror which turns all warnings into errors. However, the same line does not cause trouble in main. When building GRASS84 in the workflow without openMP, a flag -Wno-error=unknown-pragmas could be added, but this might not be the root cause for the difference between main and G84 when building without openMP.

[nilason]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66943 Is probably related. It will likely be fixed by bumping

grass/.github/workflows/gcc.yml

Line 22 in 8ebc055

runs-on: ubuntu-22.04

to ubuntu-24.04.

[metzm]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66943 Is probably related. It will likely be fixed by bumping

grass/.github/workflows/gcc.yml

Line 22 in 8ebc055

runs-on: ubuntu-22.04

to ubuntu-24.04.

Getting somewhere without bumping the ubuntu version. It seems that a build for G84 has not been triggered in a while, a number of issues pop up, not related to the purpose of this PR. E.g. doc/howto_release.md is not properly formatted which is completely unrelated to my attempts to fix the mess with the v.patch backport.

[echoix]

It looks like the ubuntugis ppa is down