Repository navigation
grass.pygrass.vector: Fix for Wrong number of arguments in a call to update_odict - #7394
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
petrasovaa
approved these changes
May 18, 2026
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
…update_odict (OSGeo#7394) Fix for Wrong number of arguments in a call If you look at all the usages of the update_odict function, there is only one place where it is called with arguments. All other places are without arguments. Adding `self` here is wrong. Removing the extra `self`. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you look at all the usages of the update_odict function, there is only one place where it is called with arguments. All other places are without arguments. Adding
selfhere is wrong.Removing the extra
self.The fix is to call
update_odictwith the correct arity, consistent with its other usage in the same class.Best fix (no functional change): in
python/grass/pygrass/vector/table.py, withinColumns.__setitem__, replace:self.update_odict(self)with:
self.update_odict()No new imports, helper methods, or definitions are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.