Repository navigation
Conversation
The Spearfish RGB example pointed at http://wms.jpl.nasa.gov/wms.cgi with layer global_mosaic. The host stopped responding years ago, so the example no longer runs. Switch to the NASA GIBS WMS endpoint with the permanent BlueMarble_ShadedRelief_Bathymetry layer (verified via GetCapabilities). Also update the r.in.wms call from the deprecated mapserver= parameter to the current url= parameter. Did not run the example end-to-end (no local GRASS install + Spearfish dataset on hand); reviewers may want to validate the screenshots / output for the new layer. AI-assisted by Claude Code. Fixes OSGeo#4844
|
Can you check this PR: #4897. It was already reviewed a couple rounds and was almost ready to merge, but was missing a round. Also, another recent (duplicate) PR exists #7372. All of them are linked in the issue you found (good first issue label), so you could always take a look at the existing PRs before starting work, and adding a new one to review |
|
Apologies for the duplicate — I should have checked the existing PRs linked from #4844 before opening this. Closing in favor of the prior work (#4897 by @rohannallamadge, which has earlier review history; and #7372 by @mvanhorn). Happy to help close those out via review comments if useful, but I won't add a third duplicate to the queue. Thanks for the feedback @echoix. |
|
What I wouldn’t mind though, if #7372 isn’t already doing that, is to take the branch of #4897 as the starting point of your branch in your fork, keep his commits as is for attribution, and refresher the PR, and address the remaining review needed. Yes, it’ll end up being a completely separate PR, but at least merging it will close all of them. |
Description
The Spearfish RGB example in
r.out.vtk.{md,html}points athttp://wms.jpl.nasa.gov/wms.cgiwith layerglobal_mosaic. That host stopped serving years ago, so the example no longer runs.This PR swaps in the NASA GIBS WMS endpoint and a permanent layer, and updates the
r.in.wmsinvocation from the oldmapserver=parameter to the currenturl=parameter:The downstream
r.out.vtk rgbmaps=...line is updated to match the new output base name. Same change applied to bothr.out.vtk.mdandr.out.vtk.html(kept in sync perAGENTS.md).Motivation and context
Fixes #4844.
How has this been tested?
curltimeout).BlueMarble_ShadedRelief_Bathymetryis present in the GIBS WMSGetCapabilitiesresponse.url=is the currentr.in.wmsparameter name by readingscripts/r.in.wms/r.in.wms.py.Screenshots (if appropriate)
None — see the testing caveat above.
Types of changes
Checklist
AI-assisted by Claude Code.