Repository navigation
CI: Bind documentation job to explicit environment context (#7288) - #7439
Closed
ArthPatel1502 wants to merge 0 commit into
Closed
ArthPatel1502 wants to merge 0 commit into
ArthPatel1502 wants to merge 0 commit into
Conversation
github-actions
Bot
added
CI
Member
|
You have extra files unrelated to the change commited here |
Member
|
Once cleaned up, then we’ll need someone with admin rights to add the environment in the settings. I can’t do it on my own. |
Member
|
It might be a good idea to make a list/table in the issue of what secrets need to be in which environments, so they could be set up, and do all the changes in a single, focused PR. For sure there isn’t only the docs one. |
ArthPatel1502
force-pushed
the
feature/use-environment-secrets-7288
branch
from
June 1, 2026 03:19
fc90a48 to
ec30ce7
Compare
Contributor
Author
|
Apologies for the noise! I have successfully hard-reset the branch against upstream main to completely remove the unrelated CLI and refactor commits. I've also re-applied the environment parameter to the documentation workflow with correct indentation to fix the check failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue by adding an explicit environment definition to the documentation workflow, matching the project requirements.
Closes #7288