Repository navigation
Octree review - #7441
Closed
ArthPatel1502 wants to merge 8 commits into
Closed
Octree review#7441ArthPatel1502 wants to merge 8 commits into
ArthPatel1502 wants to merge 8 commits into
Conversation
github-actions
Bot
added
CI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /* Point structure */ | ||
| typedef struct { | ||
| double x, y, z; | ||
| void *user_data; /* Arbitrary user pointer to attach point IDs or metadata */ |
Contributor
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| void *user_data; /* Arbitrary user pointer to attach point IDs or metadata */ | |
| void | |
| *user_data; /* Arbitrary user pointer to attach point IDs or metadata */ |
Contributor
|
@ArthPatel1502 thanks for the interest here. This PR includes the commits from #7324 and targets the same new lib/octree, so it duplicates that open PR. The specific idea, linking per-point attributes back to source records, is already being handled there: #7324 adds a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the OctreePoint3D struct to include a user_data tracking pointer, allowing downstream GRASS vector modules to link attributes directly to spatial nodes.