Skip to content

wxGUI/history: Handle 3D region data - #7444

Open
lindakarlovska wants to merge 2 commits into
OSGeo:mainfrom
lindakarlovska:wxGUI-history-handle-3d-region-data
Open

lindakarlovska wants to merge 2 commits into
OSGeo:mainfrom
lindakarlovska:wxGUI-history-handle-3d-region-data

Conversation

@lindakarlovska

@lindakarlovska lindakarlovska commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

This adds the support for 3D region data handling in History pane. Older history records that do not store 3D values are now treated as incomplete.

Main points

  • Region of executed command is newly stored with 3D params
  • Region values are now shown in two sections:
    2D parameters
    3D parameters

If a history entry has no stored 3D params (older JSON records), the 3D parameters section shows:
Unavailable for this history entry

Region comparison now has 3 explicit states:

  • Region matches current region (check icon)
  • Region does not match current region (cross icon + Update current region button)
  • Region comparison with current region is incomplete (missing stored 3D parameters) - unknown icon and tooltip

Here is a single screenshot with all 3 cases side by side:
Screenshot from 2026-05-29 22-55-00

Here is the original state before this PR (only 2D params and 2 explicit states for comparison of history vs current region):
Screenshot from 2026-05-29 23-39-10

@lindakarlovska lindakarlovska added this to the 8.6.0 milestone May 29, 2026
@lindakarlovska lindakarlovska self-assigned this May 29, 2026
@lindakarlovska lindakarlovska added enhancement New feature or request GUI wxGUI related labels May 29, 2026
@lindakarlovska
lindakarlovska requested a review from petrasovaa May 29, 2026 21:43
@github-actions github-actions Bot added Python Related code is in Python libraries labels May 29, 2026
@petrasovaa

Copy link
Copy Markdown
Contributor

Regarding the region match for the incomplete cases, I would match the 2D and report that, because for most people 3D region is not useful and this could be confusing and it is somewhat temporary anyway due to the change of the format.

@lindakarlovska
lindakarlovska force-pushed the wxGUI-history-handle-3d-region-data branch from f550653 to 54c1482 Compare July 27, 2026 16:48
@lindakarlovska

Copy link
Copy Markdown
Contributor Author

Regarding the region match for the incomplete cases, I would match the 2D and report that, because for most people 3D region is not useful and this could be confusing and it is somewhat temporary anyway due to the change of the format.

Yep, I was thinking about the same solution - the simplified version is not fully exact but makes sense in this case. So I removed the third case (the question mark icon), and now there are only the check and cross cases, along with the corresponding tooltips.

@lindakarlovska
lindakarlovska requested review from petrasovaa and removed request for petrasovaa July 27, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GUI wxGUI related libraries Python Related code is in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants