Repository navigation
CI: Query base.ref instead of sha for milestone VERSION resolution - #7463
Merged
echoix merged 2 commits intoJun 7, 2026
Merged
Conversation
echoix
reviewed
Jun 1, 2026
ArthPatel1502
force-pushed
the
fix/assign-milestone-target-7374
branch
from
June 5, 2026 03:58
4e66ed8 to
5736524
Compare
echoix
approved these changes
Jun 7, 2026
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
…SGeo#7463) Updates the milestones workflow to look up the version file using the merge commit SHA instead of the default branch commit SHA returned since the changes of November 2025 to `pull_request_target`. The merge commit sha exists before and after a PR is merged, but we are using it only after a PR is merged. Even if the way a PR is merged is not "merge", like squash&merge or rebase&merge, the commit of the target branch right after the PR is merged (including that one) is returned, which is what is wanted here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7374. Updates the milestones workflow to look up the version file using the target PR base branch ref instead of the commit SHA.