[Valyrian-Code]

Description

Add unit tests for two pure helper functions in grass.jupyter.utils that
were previously untested:

• get_rendering_size — covers all aspect-ratio branches (both dimensions
  given, only width, only height, taller-than-wide, wider-than-tall) plus a
  custom-defaults case.
• get_map_name_from_d_command — covers the default map parameter, the
  per-command special cases (d.his, d.legend, d.rgb, d.shade), a
  missing parameter, and a non-string value.

Motivation and context

grass.jupyter.utils has several pure helpers with no direct test coverage.
These two are deterministic and dependency-free (no rendering or optional
mapping libraries), so they are a good, low-risk place to start adding
coverage.

How has this been tested?

pytest python/grass/jupyter/tests/grass_jupyter_utils_test.py — 14 tests
pass. ruff format and ruff check are clean.

Types of changes

• Tests

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds unit tests for pure helper functions in grass.jupyter.utils to validate rendering size calculation and map-name extraction from display commands.

Changes:

• Introduces parametrized tests for get_rendering_size() covering explicit dimensions, aspect-ratio-derived dimensions, and default sizing behavior.
• Adds tests for get_map_name_from_d_command() across common display modules and edge cases (missing parameter, non-string values).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cwhite911]

@Valyrian-Code this looks good. I just have a few additional edge cases you could add.

[Valyrian-Code]

Thanks for the review @cwhite911 - added all three edge cases in b2d28fc (map=None, the d.rgb multi-map case returning only red_map, and the two round() half-to-even cases). Ready for another look.

[Valyrian-Code]

Thanks again @cwhite911, this was a really helpful review. I enjoyed working in grass.jupyter and I'd be glad to keep helping here.

If there are other grass.jupyter issues or small things you'd like a hand with, I'm happy to pick them up. I'm also looking into the vector styling and legend ideas that came up on Discourse, and I'd love to contribute more in this area over the coming weeks.

Just point me at whatever would be most useful, and thanks for the warm welcome to the project.

[cwhite911]

Thanks @Valyrian-Code. Looks good!

[echoix]

There was a hang in a t.list on macOS, killed after 5 minutes (expecting at most seconds), 296.33s call temporal/t.list/tests/test_t_list.py::test_t_list_csv[,]. What I find interesting is a warning related to an unclosed TextIOWriter https://github.com/OSGeo/grass/actions/runs/27020186894/job/79745720633?pr=7486#step:14:1749. I wouldn’t investigate the process still running before making sure it is not only code coverage that hasn’t still finished saving the data file.

[echoix]

For the windows failure, it seems Cairo was changed in osgeo4w yesterday, in the following commit, and some patch mentioning the header file changed. jef-n/OSGeo4W@c3b8830

I didn’t have time to finish looking and understanding

[cwhite911]

For the windows failure, it seems Cairo was changed in osgeo4w yesterday, in the following commit, and some patch mentioning the header file changed. jef-n/OSGeo4W@c3b8830

I didn’t have time to finish looking and understanding

Looks like the cairo header was moved from …/include/cairo.h to …/include/cairo/cairo.h

I'll open a PR #7507.