Repository navigation
v.voronoi: fix skeleton creation - #7513
Merged
Merged
Conversation
metzm
added
bug
Contributor
Author
|
The test |
Member
There’s work going on that. |
echoix
approved these changes
Jun 7, 2026
metzm
added a commit
that referenced
this pull request
Jun 11, 2026
With recent changes to vector libs, point-in-polygon calculations became more strict. A point exactly on a boundary can not be assigned to one specific area. For skeleton creation, points on boundaries are actually desired. This PR adjusts the test in `v.voronoi` when snapping skeleton nodes to an area's boundary.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
With recent changes to vector libs, point-in-polygon calculations became more strict. A point exactly on a boundary can not be assigned to one specific area. For skeleton creation, points on boundaries are actually desired. This PR adjusts the test in `v.voronoi` when snapping skeleton nodes to an area's boundary.
neteler
removed
the
backport to 8.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes to vector libs, point-in-polygon calculations became more strict. A point exactly on a boundary can not be assigned to one specific area. For skeleton creation, points on boundaries are actually desired. This PR adjusts the test in
v.voronoiwhen snapping skeleton nodes to an area's boundary. This affects also GRASS 8.5, thus backport is needed.