Repository navigation
r.sim.water: fix buffer overflow, OpenMP data races, and flaky parallel tests - #7523
Closed
anzalkabeer wants to merge 4 commits into
Closed
anzalkabeer wants to merge 4 commits into
anzalkabeer wants to merge 4 commits into
Conversation
- Add missing bounds check exit (continue) in hydro.c loop - Replace thread-unsafe G_drand48() in OpenMP threads with thread-safe LCG PRNG - Prevent concurrency data races on shared grids by adding OpenMP atomic and critical sections
github-actions
Bot
added
raster
anzalkabeer
changed the title
Author
|
@echoix , @Valyrian-Code , this is the new PR for the following fixes are mention into the its description |
Contributor
|
Generating reference data in the test doesn't make sense. Small, focused PRs would be easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C-level PRNG thread-safety and buffer overflow fixes
The whitespace/EDITORCONFIG formatting cleanup
The synthetic parallel pytest integration and .pack file regeneration
The final test suite assertion restorations