Repository navigation
r.fillnulls: report the full list of unfilled holes - #7524
Merged
petrasovaa merged 1 commit intoJun 9, 2026
Merged
Conversation
echoix
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
v.surf.rstcannot fill some holes, r.fillnulls warns the user and is meant to list the unfilled holes so they can be examined. The list was built with a loop that never used the loop variable, so it only printed the first hole name with one leading comma per remaining hole.For three unfilled holes the message printed
, , hole_3instead ofhole_3, hole_7, hole_12.This replaces the loop with
", ".join(failed_list)so every unfilled hole is reported, and fixes two typos in the adjacent warning (wheretowere, and a straywith).The failure branch is only reached when
v.surf.rstfails on specific holes, which is not deterministic to trigger, so this keeps the existing behavior otherwise and just fixes the reporting.