Skip to content

r.fillnulls: report the full list of unfilled holes - #7524

Merged
petrasovaa merged 1 commit into
OSGeo:mainfrom
Valyrian-Code:r.fillnulls-report-unfilled-holes
Jun 9, 2026
Merged

petrasovaa merged 1 commit into
OSGeo:mainfrom
Valyrian-Code:r.fillnulls-report-unfilled-holes

Conversation

@Valyrian-Code

Copy link
Copy Markdown
Contributor

When v.surf.rst cannot fill some holes, r.fillnulls warns the user and is meant to list the unfilled holes so they can be examined. The list was built with a loop that never used the loop variable, so it only printed the first hole name with one leading comma per remaining hole.

For three unfilled holes the message printed , , hole_3 instead of hole_3, hole_7, hole_12.

This replaces the loop with ", ".join(failed_list) so every unfilled hole is reported, and fixes two typos in the adjacent warning (where to were, and a stray with).

-        outlist = failed_list[0]
-        for hole in failed_list[1:]:
-            outlist = ", " + outlist
-        gs.message(outlist)
+        gs.message(", ".join(failed_list))

The failure branch is only reached when v.surf.rst fails on specific holes, which is not deterministic to trigger, so this keeps the existing behavior otherwise and just fixes the reporting.

Copilot AI review requested due to automatic review settings June 8, 2026 19:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added raster Related to raster data processing Python Related code is in Python module labels Jun 8, 2026
@petrasovaa
petrasovaa merged commit 2ed61f8 into OSGeo:main Jun 9, 2026
26 of 27 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone Jun 9, 2026
@Valyrian-Code
Valyrian-Code deleted the r.fillnulls-report-unfilled-holes branch June 9, 2026 18:45
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module Python Related code is in Python raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants