Skip to content

t.rast3d.list: Add checks and some fixes - #7527

Merged
echoix merged 1 commit into
OSGeo:mainfrom
saket0187:Fix-methods-output-in-t.rast3d.list
Jun 10, 2026
Merged

echoix merged 1 commit into
OSGeo:mainfrom
saket0187:Fix-methods-output-in-t.rast3d.list

Conversation

@saket0187

@saket0187 saket0187 commented Jun 9, 2026 •

Copy link
Copy Markdown
Contributor

This PR tries to fix some issues discussed in #7498 and add some checks.

I will add the output format options in a separate, follow-up PR.

Edit: Regarding method=comma, I was thinking of managing it in the same way it is done in t.rast.list.

Cc: @petrasovaa @ninsbl Kindly check if anything is wrong or missing.

@github-actions github-actions Bot added temporal Related to temporal data processing Python Related code is in Python module labels Jun 9, 2026
@petrasovaa

Copy link
Copy Markdown
Contributor

Edit: Regarding method=comma, I was thinking of managing it in the same way it is done in t.rast.list.

It looks like there is a bug with method=comma, in list_stds.py:

    if not output_format:
        if method == "comma":
            output_format = "line"
        output_format = "plain"

which doesn't make sense, introduced in d2317a2.

But that's out of scope in this PR.

@saket0187

Copy link
Copy Markdown
Contributor Author

Edit: Regarding method=comma, I was thinking of managing it in the same way it is done in t.rast.list.

It looks like there is a bug with method=comma, in list_stds.py:

    if not output_format:
        if method == "comma":
            output_format = "line"
        output_format = "plain"

which doesn't make sense, introduced in d2317a2.

But that's out of scope in this PR.

Hi, yes, I noticed that bug as well!, and I plan to fix it in the upcoming format PR.
@petrasovaa / @echoix - Since this is approved, would it be possible to merge it when you have a moment? I am ready to start the follow-up PR for the format options, and having this merged first will help keep the git history clean and avoid any merge conflicts or rebase issues.

@echoix
echoix merged commit ef0e264 into OSGeo:main Jun 10, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GRASS Google Summer of Code 2026 Jun 10, 2026
@github-actions github-actions Bot added this to the 8.6.0 milestone Jun 10, 2026
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module Python Related code is in Python temporal Related to temporal data processing

Development

Successfully merging this pull request may close these issues.

3 participants