Skip to content

cmake: Remove duplicated depends for r.out.gdal - #7536

Merged
echoix merged 2 commits into
OSGeo:mainfrom
echoix-org:ai-findings-autofix/raster-CMakeLists.txt
Jun 12, 2026
Merged

echoix merged 2 commits into
OSGeo:mainfrom
echoix-org:ai-findings-autofix/raster-CMakeLists.txt

Conversation

@echoix

@echoix echoix commented Jun 11, 2026

Copy link
Copy Markdown
Member

Found with CodeQL code quality, AI findings. I think there is any reason to specify twice two of the dependencies.


Both grass_gis (lines 371 and 374) and grass_imagery (lines 373 and 377) are listed twice in the DEPENDS section for r.out.gdal. The duplicate entries should be removed to keep the build definition clean.

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@echoix
echoix requested a review from HuidaeCho June 11, 2026 11:44
@github-actions github-actions Bot added raster Related to raster data processing module CMake labels Jun 11, 2026

@nilason nilason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@echoix

echoix commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

The checks will probably fail because of the expired certificate

@echoix
echoix enabled auto-merge (squash) June 11, 2026 16:47
@echoix
echoix merged commit 00afe3b into OSGeo:main Jun 12, 2026
22 of 25 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone Jun 12, 2026
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Jul 7, 2026
@echoix
echoix deleted the ai-findings-autofix/raster-CMakeLists.txt branch September 12, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake module raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants