Repository navigation
utils: Improve email parsing when generating release notes - #7537
Merged
Merged
Conversation
…ng sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
petrasovaa
approved these changes
Jun 11, 2026
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
Potential fix for code scanning alert no. 153: Incomplete URL substring sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've reread the suggestion, and seems to work the same, and it would fix what is detected here
Potential fix for https://github.com/OSGeo/grass/security/code-scanning/473
Use structured validation for the email instead of a plain suffix check.
Best fix: parse
author_emailinto local-part and domain (split once on@), require the domain to be exactlyusers.noreply.github.com, and only then extract the GitHub username from the local-part (id+loginorlogin). If parsing/validation fails, fall back to the existing non-noreply mapping path.In
utils/generate_release_notes.py, replace theendswith("users.noreply.github.com")branch innotes_from_git_logwith exact domain validation logic. No new imports or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.