Repository navigation
v.buffer: edit in docs - module not available without GEOS - #7575
Merged
Merged
Conversation
echoix
reviewed
Jun 15, 2026
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
echoix
approved these changes
Jun 15, 2026
github-actions
Bot
added
vector
lindakarlovska
enabled auto-merge (squash)
June 15, 2026 13:00
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
* edit is docs - v.buffer is not available at all when compiled without GEOS Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com> --------- Co-authored-by: lindakladivova <l.kladivova@seznam.cz> Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v.buffer docs is saying:
For advanced users: the built-in buffer algorithm is no longer used, as we use GEOS instead. If GRASS was not compiled with GEOS support or the GRASS_VECTOR_BUFFER is defined, then GRASS generates buffers using the built-in buffering algorithm (which is still buggy for some input data).
This is not exactly true since when I compiled GRASS without GEOS support, the v.buffer was not compiled. The condition for GEOS presence is here: e5ae98f .
New suggested formulation:
For advanced users:* current v.buffer builds use GEOS for buffering. If GRASS is built without GEOS support, v.buffer is not compiled and thus unavailable. When v.buffer is available and the GRASS_VECTOR_BUFFER is defined, then GRASS generates buffers using the built-in buffering algorithm (which is still buggy for some input data).