Repository navigation
grass.script: Sanitize mapset region variables in runtime setup - #7577
Merged
Merged
Conversation
github-actions
Bot
added
Python
wenzeslaus
requested changes
Jun 16, 2026
wenzeslaus
left a comment
wenzeslaus
left a comment
Member
There was a problem hiding this comment.
You may want to handle mask as well.
Contributor
Author
|
I would like to get this merged and later add MASK separately, that's a bug in the sanitize function. |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
…o#7577) Remove mapset-specific variables (WIND_OVERRIDE, GRASS_REGION) when setting up the runtime environment in setup_runtime_env(), so they do not leak from the parent environment into a freshly initialized session. This reuses the existing sanitize_mapset_environment() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove mapset-specific variables (WIND_OVERRIDE, GRASS_REGION) when setting up the runtime environment in setup_runtime_env(), so they do not leak from the parent environment into a freshly initialized session. This reuses the existing sanitize_mapset_environment() function.
Add a parametrized pytest covering both variables through init().