Repository navigation
t.list: Check connection to prevent creating temporal database - #7580
Merged
Merged
Conversation
github-actions
Bot
added
temporal
ninsbl
requested changes
Jun 17, 2026
ninsbl
left a comment
ninsbl
left a comment
Member
There was a problem hiding this comment.
Good start. Some first comments.
We should probably also look at performance when a TGIS DB exists as discussed earlier. But that can well be a different issue...
saket0187
marked this pull request as ready for review
June 18, 2026 07:07
petrasovaa
reviewed
Jun 18, 2026
Contributor
|
Is this covered in any test? |
Contributor
|
Also, should CSV return at least the header instead of nothing? |
Contributor
Author
This code matches the current CSV output behavior. If a native TGIS DB exists but is empty, t.list currently bypasses the header logic and outputs an empty file without a header anyway. |
ninsbl
approved these changes
Jun 22, 2026
ninsbl
left a comment
ninsbl
left a comment
Member
There was a problem hiding this comment.
CSV format indeed produced an empty line if no or an empty TGIS DB in the mapset exists. So, I think this can be merged.
github-project-automation
Bot
moved this from In Progress
to Done
in GRASS Google Summer of Code 2026
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
…#7580) * Show message only for plain * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for #7576
I will update this implementation to use
format="json"fort_connectonce #7535 is merged.@petrasovaa is this sufficient for this?