Repository navigation
t.vect.univar: Add format option with plain, JSON and CSV output - #7630
Open
Valyrian-Code wants to merge 5 commits into
Open
Valyrian-Code wants to merge 5 commits into
Valyrian-Code wants to merge 5 commits into
Conversation
github-actions
Bot
added
temporal
saket0187
reviewed
Jul 4, 2026
saket0187
left a comment
saket0187
left a comment
Contributor
There was a problem hiding this comment.
Just some small initial suggestions.
Contributor
Author
|
Thanks for the review, all applied:
And good to know about the |
Contributor
Author
|
Gentle ping, this fixes #7501 and has been open since early July. Rechecked against current main: still merges cleanly, and #7913 touched the same file but in |
wenzeslaus
requested changes
Oct 21, 2026
wenzeslaus
left a comment
wenzeslaus
left a comment
Member
There was a problem hiding this comment.
So the CSV part here is basically "current output format is CSV already just make sure it is valid"?
Valyrian-Code
changed the title
Use one v.univar call for all three formats. parse_command understands format="json", so the plain and CSV paths now read the same parsed result instead of a second call with the shell format. The shell format named two keys differently and printed floats with %g, so the plain and CSV paths map missing to nmissing and percentiles to percentile_90, and format floats the same way. Checked that the plain and CSV output is unchanged, basic and extended. Drop the one character limit on the CSV separator, since arbitrary separators are allowed elsewhere, and its test with it. Pass the arguments to print_vector_dataset_univar_statistics by keyword.
Contributor
Author
|
Yes. The plain output with a comma was already CSV shaped, so the format option mostly makes it official, with comma as the default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
formatoption to t.vect.univar withplain(default),jsonandcsv, following the same pattern as t.rast.univar (#7495) and t.rast3d.univar (#7582).id,startandendplus the statistics exactly as v.univar reports them in its own JSON output, with proper types.separatorand the-uflag).testsuite/test.t.vect.univar.shsmoke test with pytest tests using deterministic attribute values, as suggested in the issue.Verified locally: plain, csv, json and extended json outputs on a two map STVDS, and all 8 new tests pass.
Fixes #7501.