Repository navigation
temporal: Remove needs_solo_run from t.vect.list and fix typos in t.vect.list & t.rast.list tests - #7636
Merged
Conversation
Member
|
The typos fixed are fine. But there's some timeouts. Is it because too much temporal tests are running at once, and they can't really be ran in parallel (the Python code backing it up must have something either slowing it down, using too much resources, or serializing operations/comms). Maybe that's the reason why it was still separated |
Contributor
Author
|
I think we can keep the |
echoix
approved these changes
Jul 9, 2026
Member
|
Please, keep at least the PR title up to date, ideally also the description, so that it fits with the changes in the PR and it is easy to use for a matching commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
@pytest.mark.needs_solo_runmarkers from the t.vect.list tests. I'm not sure why these were added before, but it seems to work perfectly fine without the restriction.I also caught and fixed one typo in the test module:
Fixed the
test_separator_rejectedtest mistakenly callingt_rast_listinstead oft_vect_list.@echoix can you check this?