Skip to content

temporal: make SQLite TGIS DB connections more robust #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninsbl merged 7 commits into from
Jul 9, 2026
Merged

temporal: make SQLite TGIS DB connections more robust #7653

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b2bcc7b
document mapset option
ninsbl Jun 23, 2026
b966d8f
add mapset option
ninsbl Jun 23, 2026
b6b8761
add tests for mapset option
ninsbl Jun 23, 2026
bfd692c
add testcase for empty VAR file
ninsbl Jun 23, 2026
0f283a2
Merge branch 'main' of github.com:ninsbl/grass
ninsbl Jul 6, 2026
b2ac187
Merge branch 'main' of github.com:ninsbl/grass
ninsbl Jul 8, 2026
d876505
make TGIS DB connections more robust
ninsbl Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions python/grass/temporal/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,8 +1375,12 @@ def connect(self, dbstring: str | None = None) -> None:
self.connection.isolation_level = None
self.connection.text_factory = str
self.cursor = self.connection.cursor()
self.cursor.execute("PRAGMA synchronous = OFF")
self.cursor.execute("PRAGMA journal_mode = MEMORY")
# busy_timeout is set to 30 seconds to avoid "database is locked" errors
self.cursor.executescript(
"PRAGMA synchronous = OFF;"
"PRAGMA journal_mode = MEMORY;"
"PRAGMA busy_timeout = 30000;"
)
elif self.dbmi.__name__ == "psycopg2":
self.connection = self.dbmi.connect(dbstring)
# self.connection.set_isolation_level(dbmi.extensions.ISOLATION_LEVEL_AUTOCOMMIT)
Expand Down Expand Up @@ -1570,13 +1574,11 @@ def execute(self, statement, args=None):
else:
self.cursor.execute(statement)
except db_errors:
if connected:
self.close()
self.msgr.error(_("Unable to execute :\n %(sql)s") % {"sql": statement})
raise

if connected:
self.close()
finally:
if connected:
self.close()

def fetchone(self):
if self.connected:
Expand All @@ -1601,27 +1603,22 @@ def execute_transaction(self, statement, mapset=None):
self.connect()
connected = True

sql_script = ""
sql_script += "BEGIN TRANSACTION;\n"
sql_script += statement
sql_script += "END TRANSACTION;"
sql_script = f"BEGIN TRANSACTION;\n{statement};\nEND TRANSACTION;"

try:
if self.dbmi.__name__ == "sqlite3":
self.cursor.executescript(statement)
self.cursor.executescript(sql_script)
else:
self.cursor.execute(statement)
self.connection.commit()
except db_errors:
if connected:
self.close()
self.msgr.error(
_("Unable to execute transaction:\n %(sql)s") % {"sql": statement}
)
raise

if connected:
self.close()
finally:
if connected:
self.close()


###############################################################################
Expand Down
Loading