Repository navigation
t.rast.list: allow method gran with where option - #7678
Merged
Merged
Conversation
github-actions
Bot
added
temporal
saket0187
reviewed
Jul 13, 2026
Co-authored-by: SAKET KUMAR MALL <72020337+saket0187@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
Come see me or Vashek when ready to merge; the missing job would only be available if all CI is rerun after merging main, but it looks fine just like this. |
petrasovaa
requested changes
Jul 14, 2026
petrasovaa
left a comment
petrasovaa
left a comment
Contributor
There was a problem hiding this comment.
It looks like the where condition is not actual tested, no?
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Member
Author
I guess it was, but not properly with "where=True". Changed that to a real temporal where and adjusted the expected return accordingly. |
petrasovaa
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step towards solving #7344 with tools instead of the API.
There did not seem to be a technical requirement to not allow a where clause with the gran method. This PR enables it.
pytests are add and all tests moved to Tools API.