Skip to content

CI: Change codecov test result upload action on macOS & Windows - #7683

Merged
echoix merged 4 commits into
OSGeo:mainfrom
echoix:codecov-action-test-macOS
Jul 17, 2026
Merged

echoix merged 4 commits into
OSGeo:mainfrom
echoix:codecov-action-test-macOS

Conversation

@echoix

@echoix echoix commented Jul 13, 2026

Copy link
Copy Markdown
Member

The PR #7607 missed to update the action in the macOS and OSGeo4W workflow. This PR makes the change in remaining workflows

The PR OSGeo#7607 missed to update the action in the macOS and OSGeo4W workflow. This PR makes the change in remaining workflows
@echoix
echoix requested a review from ninsbl July 13, 2026 13:29
@echoix
echoix marked this pull request as draft July 13, 2026 14:45
@echoix

echoix commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Something's wrong with codecov action on macos because of the way it installs and the way we break the install to only have the micromamba available... The same reason code coverage still isn't uploaded to codecov on macOS... Changing to draft

@github-actions github-actions Bot added windows Microsoft Windows specific macOS macOS specific CI Continuous integration labels Jul 13, 2026
…vailable in the current state of the runner; We uninstall homebrew in the workflow
@echoix
echoix marked this pull request as ready for review July 16, 2026 07:17
@echoix echoix changed the title CI: Change codecov test result upload action on macOS & windows CI: Change codecov test result upload action on macOS & Windows Jul 16, 2026
@echoix

echoix commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

This should now be working, as I tested an independant branch against my fork yesterday. The problem that prevented us from using codecov to upload coverage on macOS before was still there, but with this PR, it is now unblocked, allowing a future improvement.

The codecov-action is a composite action using an inline shell script, and validates that gpg is present, unless skip_validation is true. Even when using an other install method (from pypi), it still requires it even if not used. The problem, is that we can't make the composite action run inside an activated conda env, and we remove most system tools and libraries at the start of the workflow.

Note that if we would be using the wrapper downloaded from pypi (a bit slower to download and set up), it wouldn't have validated the signature with gpg anyways (just relying on pypi).

So, everything is as I would want it now.

@echoix
echoix enabled auto-merge (squash) July 16, 2026 09:58
@echoix
echoix merged commit d141869 into OSGeo:main Jul 17, 2026
27 checks passed
@echoix
echoix deleted the codecov-action-test-macOS branch July 17, 2026 06:38
@github-actions github-actions Bot added this to the 8.6.0 milestone Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration macOS macOS specific windows Microsoft Windows specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants