Repository navigation
grass.temporal: Fix end time parsing when registering relative-time maps from file (t.register) - #7717
Merged
Conversation
…aps from file (t.register) The name|start|end input file format silently misread the end time as a semantic label for relative-time datasets: maps were registered as point time and the intended end times were written as semantic labels into the raster metadata. Regression from the band references implementation (a83af32). An integer third column is now interpreted as an end time for relative time; anything else remains a semantic label. Written with the help of Claude Code.
ninsbl
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering maps into a relative-time dataset with the documented
name|start|endfile format silently produced wrong results:The end times were dropped (maps registered as point time instead of intervals) and were instead written as semantic labels — including into the raster metadata in the spatial database, where they persist even after t.remove.
The cause is the three-column disambiguation in register_maps_in_space_time_dataset(): the last column is treated as an end
time only when it parses as a datetime, which can never happen for relative time, so the semantic label branch was unconditional for relative datasets. This is a regression from the band references implementation (a83af32); the input file format documentation still describes the original behavior.
Changes:
Written with the help of Claude Code.