Repository navigation
Conversation
| if "@" in ident: | ||
| name, mapset = ident.split("@", 1) | ||
| if ":" in name: | ||
| name, layer = ident.split(":", 1) |
There was a problem hiding this comment.
| name, layer = ident.split(":", 1) | |
| name, layer = name.split(":", 1) |
There was a problem hiding this comment.
Good catch. I feel I read this pattern (or variations of it) a bit too often. In #7670 I added a private function in open_stds.py to parse components of a STDS ID string. I wonder if such a function could / should go into e.g. an utils module or core.py to not repeat this splitting many places...
There was a problem hiding this comment.
Removing semantic_label or timestamp should probably be guarded too...
|
What’s missing here to be done? |
I was considering having something like this: grass/python/grass/temporal/open_stds.py Line 35 in ddf66e9 |
|
A helper function for STDS id parsing is better suited for a separate PR. This should be good to go... |
This PR makes sure the temporal framework does not write file metadata to the source mapset of map from another mapset and that it does not write "ghost" metadata for that map in the current mapset (the C-tools should write to current anyway).
The readonly property may become useful in other contexts as well (see e.g.: #2448).
Fixes: #3394
Replaces: #7211