Repository navigation
t.rast.import: use platform-indendent tempdir default - #7742
Merged
Merged
Conversation
github-actions
Bot
added
temporal
echoix
approved these changes
Jul 17, 2026
echoix
left a comment
echoix
left a comment
Member
There was a problem hiding this comment.
Looks fine with the added changes, and still two notes, that can't really be fixed in here
ninsbl
enabled auto-merge (squash)
July 17, 2026 21:34
Member
Author
|
The number of failed tests on Windows seems relatively constant (with 8 files failing). At the same time the number of tests got reduced (357 -> 353 files). Anyway, tests for t.rast.import / t.vect.import now pass fine. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing with OSGeo4W because /tmp was hardcoded as default for unpacking the archive.
This PR changes the default to gs.tempdir(). Users can still choose a different location.
This PR also addresses a bunch of ruff formating issues in stds_import.py and ports all t.rast/vect.import tests (both shell and gunittests) to pytest.
Test-porting was done with the help of AI.
When merged, this should reduce the number of failing tests on OSGeo4W.