Repository navigation
g.extension: Skip official repo query when installing from other sources - #7746
Merged
Merged
Conversation
Updating metadata after install consulted the official grass-addons repository (git ls-remote and a clone) to identify multi-addon overview pages, even when installing from a local directory, so installs failed without internet access.
echoix
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without internet, multi-addons can't get installed locally:
The post-install metadata update queries the official grass-addons repository to identify multi-addon entries that only install an overview HTML page. That information is only meaningful (and only available) for installs from the official repository.
This passes the already-resolved source type down to both functions and skips the query unless the source is the official repository or a fork of it, mirroring the condition main() already uses before downloading. Installing a multi-addon (e.g. i.hyper) from a local directory now succeeds offline; its overview-page entry is reported by the existing "No metadata available" warning instead of being filtered out. Official-repo installs are unchanged.