Skip to content

man: Use build_manpages.py for the man page sweep in both builds - #7748

Merged
petrasovaa merged 1 commit into
OSGeo:mainfrom
petrasovaa:man-use-build-manpages
Aug 26, 2026
Merged

petrasovaa merged 1 commit into
OSGeo:mainfrom
petrasovaa:man-use-build-manpages

Conversation

@petrasovaa

Copy link
Copy Markdown
Contributor

Follow-up to #7674, suggested in its review.

The Autotools manpages target in man/Makefile and the CMake build_manpages target maintained the same logic twice: glob the markdown tree, skip pages with an up-to-date man page, skip web-only pages. This switches man/Makefile to the build_manpages.py script the CMake build already uses, so both builds share one sweep and one exclusion list (WEB_ONLY_MD). The make-side delayed evaluation and parenthesis-escaping workarounds disappear, since the script globs at run time.

Implemented with AI assistance (Claude Fable).

Replace the MANPAGES machinery in man/Makefile with a call to the
sweep script the CMake build already uses, so both builds share one
sweep and one exclusion list. The delayed-evaluation and
parenthesis-escaping workarounds are no longer needed because the
script globs the markdown tree at run time.

Implemented with AI assistance (Claude Fable).

@wenzeslaus wenzeslaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks appropriate. More common code is good. No red flags.

@petrasovaa
petrasovaa merged commit c76c23b into OSGeo:main Aug 26, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GRASS Markdown Documentation Aug 26, 2026
@petrasovaa
petrasovaa deleted the man-use-build-manpages branch August 26, 2026 02:51
@github-actions github-actions Bot added this to the 8.6.0 milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Python Related code is in Python

Projects

Development

Successfully merging this pull request may close these issues.

2 participants