Skip to content

CI: Fix inverted condition disabling ccache and mold in doc builds - #7755

Merged
echoix merged 2 commits into
OSGeo:mainfrom
wenzeslaus:fix-doc-ccache-condition
Jul 18, 2026
Merged

echoix merged 2 commits into
OSGeo:mainfrom
wenzeslaus:fix-doc-ccache-condition

Conversation

@wenzeslaus

Copy link
Copy Markdown
Member

Since #6296, the ccache and mold steps in the documentation workflow are enabled
only for workflow_dispatch, which we never run, so no build has actually used
them. The condition is inverted relative to the step name "ccache (do not use
for release artifacts)"; this flips it so push and pull request builds use
ccache and mold, matching the polarity of the adjacent setup-python steps.

Details: evidence, effect, and how it was checked (AI generated)
  • ccache was added to this workflow unconditionally in CI(docs): Add ccache to builds #5641; mold was also
    unconditional. CI: Fix and enable scanning GitHub Actions with actionlint and zizmor #6296 added the if: gates as part of zizmor cache-poisoning
    mitigation.
  • The intended polarity is visible in the same commit: "Set up Python (with
    cache)" runs on push/pull_request (contains(...)), "Set up Python (no
    cache, use for release artifacts)" runs otherwise (!contains(...)). The
    ccache and mold steps received the release-only condition instead, despite
    the ccache step being named "do not use for release artifacts".
  • The workflow's only non-push/PR trigger is workflow_dispatch, which is not
    used in practice; release artifacts are built from tags by
    create_release_draft.yml, and this workflow's artifacts have 3-day
    retention. So since September 2025 the two steps have not run in any build,
    and every documentation build (core build, addons compile, doxygen) has
    compiled without ccache and linked without mold.
  • The !contains condition on the uncached setup-python step is correct and
    left unchanged.
  • Checked with pre-commit run on the file: yamllint, actionlint, and zizmor
    all pass; no new zizmor ignore comment is needed.

The inverted condition was identified and the fix prepared with AI assistance
(Claude Code with Fable 5).

@echoix echoix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that and thought I had created a PR or at least a branch for it, but I never did apparently

@echoix
echoix enabled auto-merge (squash) July 17, 2026 21:35
@github-actions github-actions Bot added the CI Continuous integration label Jul 18, 2026
@echoix
echoix merged commit 5394d8e into OSGeo:main Jul 18, 2026
26 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants