Repository navigation
CI: Fix inverted condition disabling ccache and mold in doc builds - #7755
Merged
Merged
Conversation
echoix
approved these changes
Jul 17, 2026
echoix
left a comment
Member
There was a problem hiding this comment.
I noticed that and thought I had created a PR or at least a branch for it, but I never did apparently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6296, the ccache and mold steps in the documentation workflow are enabled
only for workflow_dispatch, which we never run, so no build has actually used
them. The condition is inverted relative to the step name "ccache (do not use
for release artifacts)"; this flips it so push and pull request builds use
ccache and mold, matching the polarity of the adjacent setup-python steps.
Details: evidence, effect, and how it was checked (AI generated)
unconditional. CI: Fix and enable scanning GitHub Actions with actionlint and zizmor #6296 added the
if:gates as part of zizmor cache-poisoningmitigation.
cache)" runs on push/pull_request (
contains(...)), "Set up Python (nocache, use for release artifacts)" runs otherwise (
!contains(...)). Theccache and mold steps received the release-only condition instead, despite
the ccache step being named "do not use for release artifacts".
used in practice; release artifacts are built from tags by
create_release_draft.yml, and this workflow's artifacts have 3-day
retention. So since September 2025 the two steps have not run in any build,
and every documentation build (core build, addons compile, doxygen) has
compiled without ccache and linked without mold.
!containscondition on the uncached setup-python step is correct andleft unchanged.
pre-commit runon the file: yamllint, actionlint, and zizmorall pass; no new zizmor ignore comment is needed.
The inverted condition was identified and the fix prepared with AI assistance
(Claude Code with Fable 5).