Repository navigation
contributing: Use SPDX copyright tags in the most complicated file headers - #7763
Merged
Merged
Conversation
cwhite911
previously requested changes
Jul 20, 2026
wenzeslaus
force-pushed
the
spdx-final-notices
branch
5 times, most recently
from
August 29, 2026 10:32
84e9a53 to
d2a0452
Compare
…aders Convert 23 files whose headers needed reading in full. r.sun names Jaro Hofierka with GeoModel, s.r.o. as his affiliation on one line for 2002, with 2011 Hamish Bowman in rsunlib.c. Postal addresses and email lists are not carried into holder lines. The team clause in main.c keeps its own years on the collective line. The lib/rst interp_float files convert with the identifier by maintainer decision: r.resamp.rst in the same code family states the GPL explicitly with the same holders. The McCauley files in v.perturb, v.qcount, and v.normal use the name alone, because the line with the email address would pass the 80-column limit at which clang-format breaks the tag. Bill Brown's email fits and stays in r.surf.area. v.lrs.segment/main.c is MIT licensed and converts to SPDX-License-Identifier: MIT, with Radim Blazek and Hamish Bowman on their own lines and the license text replaced by the identifier, the same operation as for the GPL files. Four files are deferred as third party: mysql_config is Oracle's, gitlog2changelog.py is Marcus D. Hanwell's via NUT, and two files under man are vendored web assets. The edits were applied by a per-file replacement script that asserts each old text occurs exactly once and that trailing bytes never change. Written with AI assistance (Claude Code with Opus 4.8 and Fable 5); the decisions are the author's.
wenzeslaus
force-pushed
the
spdx-final-notices
branch
from
August 29, 2026 10:34
d2a0452 to
7004a37
Compare
wenzeslaus
dismissed
cwhite911’s stale review
September 4, 2026 02:07
Addressed in a comment and approved by @nilason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts 23 files whose headers needed reading in full: r.sun, the RST interpolation library, the McCauley tools, and the MIT-licensed v.lrs.segment.
2002 Jaro Hofierka, GeoModel, s.r.o.; postal addresses and email lists stay out of holder lines.SPDX-License-Identifier: MITwith its two holders on their own lines.mysql_config,gitlog2changelog.pyfrom NUT, and two vendored web assets underman.The policy decisions were made during GRASS Community Meeting 2026 in San Michele all'Adige.
Like the other conversion PRs, this should technically merge after #7749, which defines the "GRASS Development Team" line, but it does not have to.
The edits were applied by a per-file replacement script that asserts each old text occurs exactly once and that trailing bytes never change. The script was written and this conversion prepared with AI assistance (Claude Code with Opus 4.8 and Fable 5); the decisions are the author's.
Details: decisions, deferred files, and how it was checked (AI generated)
Decisions
2002 Jaro Hofierka, GeoModel, s.r.o.(GeoModel is his affiliation, kept on the same line), plus2011 Hamish Bowmanon his own line in rsunlib.c. Contact information goes with the notice. The separate team clause in main.c keeps its years on the collective line (2003-2013 GRASS Development Team); rsunlib.c shares its clause with Hamish Bowman, so its collective line is bare. The FSF license block each file carried in a separate comment is replaced by the identifier.Copyright 1993, H. Mitasova (University of Illinois), I. Kosinovsky, (USA-CERL), and D.Gerdes (USA-CERL)with no license text. One holder per line, affiliations kept; theWritten byandmodified bylines are untouched.1994 James Darrell McCauley(or1994-1995), name only. With the email the line is 81 to 86 columns; clang-format wraps comments at 80 and would break the tag. Bill Brown's1994 Bill Brown, USACERL <brown@gis.uiuc.edu>fits at 77 columns and keeps the email in r.surf.area.2004-2007 Radim Blazek <blazek@itc.it>and2004-2007 Hamish Bowman (side_offset bits), thenSPDX-License-Identifier: MITreplacing the license text, the same operation as for the GPL files. This is the one file in the series with a license other than GPL-2.0-or-later.Deferred as third party (4 files)
mswindows/osgeo4w/mysql_config: Oracle's script, GPL version 2 only.utils/gitlog2changelog.py: Marcus D. Hanwell's, via the NUT project.man/jquery.fixedheadertable.min.js,man/parser_standard_options.css: vendored web assets.Checked
Each replacement asserts the old text occurs exactly once and trailing bytes never change. Across the 23 files: no license prose remains, no emitted line exceeds 80 columns, and
pre-commitpasses with nothing reformatted, verified with hooks actually running. clang-format adjusted whitespace in the four interp_float headers after the initial edit; the committed text is the hook-stable form, re-verified as a byte-level no-op. The script (resolve_final.py.txt) is attached.resolve_final.py.txt