Repository navigation
r.geomorphon: check region rows against search radius before reading - #7773
Merged
Merged
Conversation
While working on parallelizing r.geomorphon, I found a small bug in the serial code. When the region has fewer rows than the search radius needs, the module fails without saying why. It just gives a confusing library message about the symptom, not the cause. This small PR adds an early check with an error message that tells the user their search value needs more rows than the region has, and what the minimum is.
github-actions
Bot
added
raster
cwhite911
requested changes
Jul 25, 2026
petrasovaa
requested changes
Jul 26, 2026
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
petrasovaa
approved these changes
Jul 26, 2026
petrasovaa
enabled auto-merge (squash)
July 26, 2026 21:13
cwhite911
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on parallelizing r.geomorphon, I found a small bug in the serial code.
When the region has fewer rows than the search radius needs, the module fails without saying why. It just gives a confusing library message about the symptom, not the cause.
This small PR adds an early check with an error message that tells the user their search value needs more rows than the region has, and what the minimum is.