Repository navigation
r.resamp.stats: Fix quantile option being truncated to an integer - #7791
Merged
Merged
Conversation
The quantile variable is a double, but its value was parsed with atoi, so any quantile below 1.0 became 0 and method=quantile returned the minimum regardless of the requested quantile. Use atof, as r.neighbors, r.series and r3.neighbors already do for the same option.
github-actions
Bot
added
raster
petrasovaa
approved these changes
Aug 3, 2026
petrasovaa
left a comment
petrasovaa
left a comment
Contributor
There was a problem hiding this comment.
The fix is fine, but please don't leave AI response in the PR description, it is very annoying.
Contributor
Author
|
@petrasovaa Just being honest here , I thought the fix is what matters and pr description should just describe what the fix is . If it's formatted through AI , it shouldn't be the problem I guess . Well I will keep that in mind whenever I will raise another PR. |
Contributor
|
See the first sentence of the PR description, please just be more careful what you paste. |
Contributor
Author
|
Okay I will edit , I understand it was in hurry bury |
Contributor
Author
|
@petrasovaa what about PR #7044 ? Can u review it please ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantileis stored as adouble, but its value was parsed usingatoi(), causing any value less than1.0to be truncated to0. As a result,c_quant()always received0as the requested quantile, returning the minimum value. This meant thatmethod=quantileeffectively behaved asmethod=minimum, and thequantileoption had no effect.Verification
Verified on the
Comparison | Difference -- | -- quantile=0.5 vs. minimum | 0 ... 0 (identical) quantile=0.9 vs. minimum | 0 ... 0 (identical) quantile=0.5 vs. median | -21.67 ... 0 (expected to be 0)nc_spm_08_grass7dataset withres=100:Fix
Replace
atoi()withatof()so fractional quantile values are parsed correctly.This matches the implementation used by other GRASS modules exposing the same option, including:
r.neighborsr.seriesr3.neighborsNotes
Found while reviewing #7044 and submitted as a separate PR, as requested, to keep the fix independent.