Repository navigation
r.reclass.area: preserve backwards compatibility - #7806
Conversation
ninsbl
left a comment
There was a problem hiding this comment.
Thanks for the fix. I overlooked the inconsistency. Should this be mentioned in the manual, also your comment on the rmarea method?
IMHO, the previous inconsistency does not need to be mentioned in the manual since you fixed it with the new options. The current behaviour, when are areas removed and when are areas merged with neighbours, should be added to the manual. The name of the module itself, |
|
@ninsbl You are welcome to improve my changes to the manual regarding the new |
ninsbl
left a comment
There was a problem hiding this comment.
Looks good. Just some autocomplete issues from your IDE...
|
Also: make sure the typos in the title and the commit message are fixed before merging (relclass -> reclass) |
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
ea785fc to
f1944bc
Compare
Up to G85, there was a inconsistency in the behaviour of
r.reclass.area:mode=lesser method=rmarearemoved areas smaller thanvalue, whereasmode=lesser method=reclassremoved areas larger thanvalue.PR #7337 fixed this inconsistend behaviour with the introduction of the new options
lowerandupper, replacing themodeandvalueoptions up to G85. This is great! But handling of backwards compatibility did not take into account the inconsistency in the behaviour up to G85. This PR fixes the backwards compatibility of PR #7337.