Repository navigation
v.random: migrate tests from gunittest to pytest - #7822
Merged
Merged
Conversation
Cover the same three cases as the gunittest testsuite: the requested number of points is created, the -z flag with zmin/zmax produces a 3D map, and restrict= keeps points inside a given area. Replace the nc_state sample vector with a synthetic area (v.in.region on a sub-region) so the test needs no dataset, and read topology via v.info -t format=json.
github-actions
Bot
added
vector
There was a problem hiding this comment.
Pull request overview
This PR migrates v.random’s test coverage from legacy gunittest (testsuite/) to pytest (tests/), aligning v.random with the project’s ongoing move toward pytest-based testing.
Changes:
- Remove the existing gunittest-based test module for v.random.
- Add a new pytest-based test module which creates a synthetic restrict area using
v.in.regionand validates point count, 3D output, andrestrict=behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vector/v.random/testsuite/test_v_random.py | Removes the legacy gunittest-based tests. |
| vector/v.random/tests/v_random_test.py | Adds pytest equivalents using a temporary GRASS project and synthetic restrict area. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The topology checks in test_points_are_3d were dedented to module level, where flake8 rightly flags tools as undefined (F821). Indent them back into the test.
Contributor
Author
|
Dropped overwrite=True from the fixture here too, same reason, the fresh project per test makes it unnecessary. |
petrasovaa
reviewed
Aug 20, 2026
petrasovaa
requested changes
Aug 20, 2026
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Contributor
Author
|
Added the SPDX-License-Identifier line, thanks for the pointer. |
This was referenced Aug 27, 2026
echoix
added
the
conflicts/needs rebase
# Conflicts: # vector/v.random/testsuite/test_v_random.py
Contributor
Author
echoix
removed
the
conflicts/needs rebase
ToolResult.__getitem__ proxies to the parsed JSON, so subscripting the result directly is equivalent. Applies the same change to the other three calls, as asked in review.
Contributor
Author
|
Sorry, I missed the "and elsewhere" and only kept your line. Dropped |
petrasovaa
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates v.random's tests from gunittest to pytest, part of the effort to support writing tests with pytest.
The new
vector/v.random/tests/v_random_test.pykeeps the same three cases as the oldtestsuite/test_v_random.py:-zflag withzmin/zmaxproduces a 3D point maprestrict=keeps every point inside the given area (clipping by that area removes none)To avoid depending on the NC sample dataset, the
nc_statevector is replaced with a synthetic area created from a sub-region viav.in.region, and topology is read viav.info -t format=json. Verified locally on GRASS 8.5, all three pass.